Fix DictionaryProperty valid_types bugs, and other misc property issues #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
work as valid_types, and fix some bugs. - DictionaryProperty.__init__()'s valid_types argument now accepts either property classes or instances - DictionaryProperty now correctly propagates allow_custom down to its valid_types properties, and propagates their returned has_custom flag upward - DictionaryProperty's cleaned dictionaries actually contain the cleaned values now (before, the cleaned values were ignored) Property class cleanup: - Property subclass .clean() methods now are correct overrides of the base class method, including parameter naming and default values - OpenVocabProperty now doesn't treat any value as custom, regardless of the allow_custom setting, which was our original intent. A violation of strict mode now causes ValueError to be raised, not CustomContentError. - BooleanProperty.clean() now honors strict=True (it will only accept values True and False in that case). Added various property tests of strictness, and additional DictionaryProperty tests which exercise custom value detection when used with ReferenceProperty.
rpiazza
merged commit 92231d9
into
oasis-open:relational-data-sink
1 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DictionaryProperty so that EnumProperty and ReferenceProperty both work as valid_types, and fix some bugs.
Property class cleanup:
Added various property tests of strictness, and additional DictionaryProperty tests which exercise custom value detection when used with ReferenceProperty.